backbone-nested icon indicating copy to clipboard operation
backbone-nested copied to clipboard

Published 20 hours ago • verified publisher icon afeld

test case for issue #60

Open tomhicks opened this issue 10 years ago • 7 comments

demonstrates issue where setting a value inside a nested array erroneously triggers an add event, when no item has been added

tomhicks avatar May 11 '14 20:05 tomhicks

I meant "issue #60" not "PR #60" in the title but I can't edit it - 422 (Unprocessable Entity)

tomhicks avatar May 11 '14 20:05 tomhicks

So, this PR should create a failing testcase?

gkatsev avatar May 11 '14 20:05 gkatsev

Yep. I'm having a look at the fix now.

I'm not suggesting this should be merged yet,

tomhicks avatar May 11 '14 20:05 tomhicks

Yeah, totally, just wanted to make sure I'm understanding it correctly. :smile_cat:

gkatsev avatar May 11 '14 20:05 gkatsev

#60 was raised 2 years ago, yet this is a very popular Backbone extension - what happened?! (Maybe I'll find out it's really hard to fix and that's the reason!)

tomhicks avatar May 11 '14 20:05 tomhicks

I'm not convinced that this is either the most efficient, or the most robust way of tackling this. Seems to do the job though.

I reckon this is ready to merge if no-one reckons we need more tests around this.

tomhicks avatar May 11 '14 22:05 tomhicks

Any news on this one?

tomhicks avatar May 12 '14 23:05 tomhicks