hulk

Results 524 comments of hulk

> > @StarlightIbuki So do you suggest adding the `Vary` response header while hitting the cache in this PR? > > We need to add content from the `Vary` header...

> Note we also need to make sure there are no duplicated headers. Sure, thanks for your reply. I will take care of this condition. I won't submit an issue...

@StarlightIbuki That's great, thanks a lot for your help.

@StarlightIbuki @chronolaw Can you take a look at #12876 while you get time?

@Beihao-Zhou Done, thanks for your efforts.

> The patch LGTM. But CI still failed lol Yes, maybe I should print the replication first when failed.

Hi @DMwangnima Thanks for your interest, assigned to you. But to be noticed, this would depend on issue #1753. But you can propose a solution if you don't mind.

> Got it. I would do some preliminary preparations first. Thank you! Feel free to raise any discussion or question if you like.

@DMwangnima You can go ahead since https://github.com/apache/kvrocks/issues/1753 has been merged.

@DMwangnima Sure, thanks for your feedback.