kvrocks Feat: add support of XCLAIM

close #1733

[x] Add Unit Tests

Design: https://github.com/apache/kvrocks/discussions/1654 Redis doc: https://redis.io/commands/xclaim/

Mar 26 '24 17:03 Beihao-Zhou

Hi @Yangsx-1! I have a question about MakeCmdAttr. What are first_key, last_key, and key_step for here? Also for the description field, should I have no-dbsize-check for XCLAIM? Thanks a lot!!

Mar 26 '24 17:03 Beihao-Zhou

Hi @Beihao-Zhou. First_key, last_key, and key_step are Redis key range. For this command, it will be 1 1 1. In my opinion, this command could not add the no-dbsize-check flag, no-dbsize-check is only added to the command which can make the db smaller.

Mar 27 '24 00:03 jihuayu

Hi @Beihao-Zhou. First_key, last_key, and key_step are Redis key range. For this command, it will be 1 1 1. In my opinion, this command could not add the no-dbsize-check flag, no-dbsize-check is only added to the command which can make the db smaller.

I see I seem thank you very much!!

Mar 27 '24 12:03 Beihao-Zhou

@Beihao-Zhou Thanks for your patch. Can you fix the CI first? https://github.com/apache/kvrocks/actions/runs/8500498583/job/23284955556?pr=2202#step:7:1062

Apr 01 '24 00:04 jihuayu

@Beihao-Zhou Thanks for your patch. Can you fix the CI first? https://github.com/apache/kvrocks/actions/runs/8500498583/job/23284955556?pr=2202#step:7:1062

Sry for the late reply. Sure thing, it's fixed now! I've ran both ./x.py check tidy and ./x.py format locally, but fails to run ./x.py check golangci-lint as it kept hanging there and being killed eventually. I'm wondering if any maintainer can trigger the workflow for me in this PR? Thanks!!

Apr 02 '24 15:04 Beihao-Zhou

@Beihao-Zhou Done, thanks for your efforts.

Apr 02 '24 15:04 git-hulk

@Beihao-Zhou You can enable action in your fork repo,it is free!

Apr 03 '24 03:04 jihuayu

@Beihao-Zhou You can enable action in your fork repo,it is free!

Thanks for telling me that!!

Apr 03 '24 12:04 Beihao-Zhou

You can fix the CI first.

Sure thing, will fix it and modify code this weekend!

Apr 25 '24 12:04 Beihao-Zhou

@Yangsx-1 Hiii! Code and CI are fixed (CI succeeds on my fork). Could you please take a look at the PR again? Thanks!!

Apr 29 '24 22:04 Beihao-Zhou

Also wondering does anyone know why the linting check couldn't pass as shown with errors (https://github.com/Beihao-Zhou/kvrocks/actions/runs/9052637137/job/24870567712#step:7:1493).

May 12 '24 16:05 Beihao-Zhou

Also wondering does anyone know why the linting check couldn't pass as shown with errors (https://github.com/Beihao-Zhou/kvrocks/actions/runs/9052637137/job/24870567712#step:7:1493).

@Beihao-Zhou The PR #2276 modified the variable name and the clang-tidy told you the variable name is wrong.