hulk
hulk
``` --- FAIL: TestWaitBlockExecutingCommand (3.34s) wait_test.go:279: Error Trace: /home/runner/work/kvrocks/kvrocks/tests/gocase/unit/wait/wait_test.go:279 Error: Not equal: expected: "v3" actual : "v2" Diff: --- Expected +++ Actual @@ -1 +1 @@ -v3 +v2 Test: TestWaitBlockExecutingCommand...
I personally don't like the idea to bind the proxy to the cluster, because only for the specific scenario and it's strange to bind the LB address in to the...
@guozhihao-224 Assigned, thank you!
> Note that from this release, C++20 is required. cc @git-hulk @mapleFU > > Hence unless c++20 enabled for Kvrocks, we cannot upgrade to this release (or future releases). Could...
> As I think, now we can merge this PR into upstream? Yes, I think it's good to go.
@hll1213181368 What do we need to stop the key scanning when the master becomes the slave role? I feel it's a bit strange to do that.
@salarali Could you increase the value of [rocksdb.blob_garbage_collection_age_cutoff](https://github.com/apache/kvrocks/blob/unstable/kvrocks.conf#L965C1-L965C44) to enable the more aggresive compaction? You can change this value via the `config set rocksdb.blob_garbage_collection_age_cutoff 40` to see if more blob...
@salarali Thanks for your confirmation. You can disable the blob files first to mitigate this issue. The last related issue is #2604, but it's a known issue in RocksDB and...
@zhixinwen Thanks for your report. > should we only return OK if the connection is in ASKING mode? And yes, I think it makes sense to allow the destination node...
> However, the dest node would still have imported_slots_ set and it could potentially receive some writes MOVED from old source node. In this case, some writes would still be...