hulk comments

Results 525 comments of


                                            hulk

Refactor the management of rocksdb ColumnFamily

> Also, we should have a better abstraction of the management of column families. > > Currently it's too hard to maintain, and these adhoc logic about column families is...

Optimization of Lua Global Locks

@i18n-now Thanks for your suggestion.

chore(prometheus): improve logging when having the inconsistent labels count

@oowl Would you mind taking a look at this PR?

chore(prometheus): improve logging when having the inconsistent labels count

https://github.com/Kong/kong/actions/runs/9072858739/job/24943120249?pr=13020#step:20:2126 The CI failure is not related to this PR.

chore(prometheus): improve logging when having the inconsistent labels count

@chronolaw @StarlightIbuki could you help to take a look at this PR?

fix(router/atc): uri replace didn't works well if contains the optional group

This PR is ready to review now. Could you please take a look while you have time? I'm not sure if I get your point correctly.

fix(router/atc): uri replace didn't works well if contains the optional group

@StarlightIbuki Thank you, I did enable the .editorconfig plugin in my IDE, but it seems didn't work correctly. Will take care of this next time.

fix(router/atc): uri replace didn't works well if contains the optional group

@StarlightIbuki @chronolaw Please take a look at the last commit again.

fix(proxy-cache): set Header `Accept-Encoding` as default values of vary_headers

@chronolaw @oowl could you help to take a look at this PR?

fix(proxy-cache): set Header `Accept-Encoding` as default values of vary_headers

@StarlightIbuki So do you suggest adding the `Vary` response header while hitting the cache in this PR?