George Knee

Results 159 comments of George Knee

For the abigen v2 route see the sketch code here: https://github.com/statechannels/go-nitro/compare/abigenv2?expand=1#diff-108f221519228166f68fe014cb4428e8cb8cb434a564a008109ae9c611d60a2cR165-R177 The real advantage is that breaking changes to our solidity code API will flag immediately in the go-nitro codebase...

If the transaction is to be **prepared** by `go-nitro` and then **signed** by the consumer, it is not obvious which party is responsible for setting gas costs and account nonces....

Another failure today https://github.com/statechannels/go-nitro/actions/runs/5462348609/jobs/9941589071 [integration-test-logs (4).zip](https://github.com/statechannels/go-nitro/files/11956228/integration-test-logs.4.zip) ``` rpc_test.go:437: aliceLedger received {0x13d419d7efd461a977fac338011d1bd2e5a05170e39643e3a184e5a106ce9c0c Complete {0x0000000000000000000000000000000000000000 0x7E5F4552091A69125d5DfCb7b8C2659029395Bdf 0x2B5AD5c4795c026514f8317c7a215E218DcCD6cF 0x63 0x65}}+ rpc_test.go:437: bobLedger received {0x13d419d7efd461a977fac338011d1bd2e5a05170e39643e3a184e5a106ce9c0c Open {0x0000000000000000000000000000000000000000 0x2B5AD5c4795c026514f8317c7a215E218DcCD6cF 0x7E5F4552091A69125d5DfCb7b8C2659029395Bdf 0x64 0x64}}+ rpc_test.go:437: bobLedger received...

I'm not sure if this is the same failure or not (I think the test was renamed??) https://github.com/statechannels/go-nitro/actions/runs/6172896908/attempts/1 ``` === RUN TestRpcWithHttp/2_clients panic: test timed out after 1m0s running tests:...

The watchtower can be smart: * it can decide if it is economically sensible to spend gas on responding to a given challenge * it can also try to understand...

Initially, we will build this into the `node` (maybe it lives inside the chain service). Longer term, we may want to extract it into a separate service that could be...

Prior art: https://discovery.ucl.ac.uk/id/eprint/10090374/1/main.pdf

> I also just realized that calling challenge means the watchtower must have a copy of the SC key, so it can sign the [challenger sig](https://github.com/statechannels/go-nitro/blob/9eef251e4121147174682c0f75dc8d4e487fbd52/nitro-protocol/contracts/ForceMove.sol#L51). With checkpoint we don't...

Since we absorbed the ts client into this repo, we could also just reuse the existing create channels utility in docker ?