George Knee comments

Results 159 comments of


                                            George Knee

Support arbitrary DirectlyFunded channels

For 3, if we take the path of modifying `directfund` to not assume a consensusapp, we should ensure that. * `node.CreateLedgerChannel` still results in a `ConsensusChannel` in the store *...

Update add-chain script to handle input variations within genesis.json and rollup.json

This work is partially complete, but we need to extend it to cover custom gas token config.

Enforce address checksums in configs

Happy to carry this forward, but just pausing in case there is an opportunity to cut scope. My reasoning is as follows: I'm not totally clear on the reasons for...

Enforce address checksums in configs

I think it depends on what our aims are. If we want to use checksums as a way to catch typo errors on data coming in to the repo, taking...

Enforce address checksums in configs

This PR is stale and has merge conflicts, so I am continuing the work here on #266. I can add it to my workload for this cycle.

validation: add global chainId check

@mds1 I updated the logic to match your suggestion. I also went through the existing chains to add a short name and correct the existing names where discrepancies exist. Further,...

validation: add global chainId check

@mds1 I'm not sure why `chek-security-configs` is failing. Do you have any insight?

validation: add global chainId check

Thanks, need to get better at parsing those traces :-) Is there anything we can do to make that easier? > (I did not realize Base Sepolia upgraded to FPAC...

validation: add global chainId check

In favour of #320

adding a chain: allow filename to be distinct from chain name

This will be solved by #320