George Knee
George Knee
Proposed changes: ## `optimism` monorepo The genesis creation script should store a new file `genesis-creation-metadata.json` (or, could we just a new field to the `genesis.json` file?) Inside, it lists: *...
Let me try to clarify this a bit. I think there are the following two approaches to genesis validation: ## "compile & ignore immutables" This is exactly as you describe...
We went with the "regenerate genesis exactly" approach, and are now storing the information in the registry as desired. We can close this ticket when we update the genesis creation...
@bitwiseguy implemented this here https://github.com/ethereum-optimism/optimism/pull/11763 but it has been decided we will take a different approach and make a tag for chain operators to use to generate their L2 genesis...
I think this command would benefit from some e2e tests. I noticed today that it also adds hardfork times to the config file, which I don't think we want.
I think in the short term it is not a big deal, if we remove a chain we can just make sure to not touch the bytecodes database. Then, when...
#366 added a `remove-chain` command.
This job can also enforce that `superchain_level: 2` and `standard_chain_candidate = true` should not both appear in a config file.
Be nice to have all the standard config checks in a single test file, so that checks not related to standard config are kept separate.
One area that seems particularly brittle is the parsing of the standard TOML files. Coupled with the approach we take to ignore empty structs in several places, small typos break...