go-nitro icon indicating copy to clipboard operation
go-nitro copied to clipboard

Implement create-channels scripts

Open kerzhner opened this issue 2 years ago • 3 comments

The Typescript client has a create-channels utility that is useful for bootstrapping nitro nodes for manual tests. If we reimplement the utility in golang, we can use the utility when spinning up go-nitro nodes via docker. This allows for one make command to spin up an image with ledger and virtual channels created.

kerzhner avatar Jun 23 '23 13:06 kerzhner

Since we absorbed the ts client into this repo, we could also just reuse the existing create channels utility in docker ?

geoknee avatar Jul 14 '23 12:07 geoknee

Since we absorbed the ts client into this repo, we could also just reuse the existing create channels utility in docker ?

We could, but this requires setting up node/yarn in docker. This will increase the docker image size and lengthen docker builds. Plus https://github.com/statechannels/go-nitro/pull/1408 is almost finished.

kerzhner avatar Jul 14 '23 14:07 kerzhner

Since we absorbed the ts client into this repo, we could also just reuse the existing create channels utility in docker ?

We could, but this requires setting up node/yarn in docker. This will increase the docker image size and lengthen docker builds. Plus #1408 is almost finished.

Good point. I went down that path today when playing around with embedding the GUI into go-nitro using Docker. A bit of food for thought.

geoknee avatar Jul 14 '23 16:07 geoknee