George Knee

Results 159 comments of George Knee

Resolved genesis integrity checks upstream and rebased. CI is now passing that.

Documenting a lighter-weight solution for changelog generation: ``` git cliff --include-path "op-node/**/*" --include-path "op-service/**/*" --tag-pattern "op-node/*" -- op-node/v1.13.3..HEAD ``` https://git-cliff.org/ With this template https://github.com/orhun/git-cliff/blob/main/examples/github.toml (only `git.filter_unconventional = false`).

Whatever solution we use for generating release notes or changelogs, it would be awesome to commit it to the codebase -- either in the monorepo directly or into `op-workbench`. The...

If we wired up e.g. `./op-workbench release-notes op-batcher` to automagically execute: ``` git cliff --include-path "op-batcher/**/*" --include-path "op-service/**/*" --config-url=https://gist.githubusercontent.com/geoknee/48d0187c591b968fb21b419bc7efb80e/raw/cd402351fd859f9fcd9bdbe97c622f3f25ecb21f/git-cliff.toml --tag-pattern="op-batcher/v1.14.0-rc.2" -- op-batcher/v1.13.2..op-batcher/v1.14.0-rc.2 ``` and even push that up to github...

A draft dashboard is being developed here https://github.com/ethereum-optimism/optimism/pull/16358. Need a few things to land before it is installed into kurtosis.

This was just an experiment for local testing purposes.

A workaround is to just re-run the workflow in circle CI after the PR exists.

In favour of https://github.com/ethereum-optimism/optimism/pull/18589

7. I couldn't find an explanation of what the "normalized state diff hash" is. Be nice to include that.

1. You say the TODOs are only printing during signing, but don't we ask signers to perform the task simulation? If so, then it is part of the UX for...