superchain-registry icon indicating copy to clipboard operation
superchain-registry copied to clipboard
verified publisher icon ethereum-optimism

`promote-to-standard` has unexpected behaviour on non-standard-candidate chains

Open geoknee opened this issue 1 year ago • 1 comments

  • It should be a no-op on standard chains.

  • It should only modify the intended config file fields, it should not modify the hardfork times for instance.

geoknee avatar Jun 28 '24 20:06 geoknee

I think this command would benefit from some e2e tests. I noticed today that it also adds hardfork times to the config file, which I don't think we want.

geoknee avatar Jul 09 '24 17:07 geoknee