Gavin King comments

Results 1136 comments of


                                            Gavin King

HHH-18385 Remove java.sql.Statement logging in SqlStatementLogger

Thanks, @NathanQingyangXu, nice catch.

transaction timeout on Reactive flavor + Narayana

I thought the problem here was that Narayana itself doesn't work in a reactive way. Has that changed since I last asked >5 years ago?

Support `@IdGeneratorType`

Ooooh, I guess we didn't consider the impact this would have on Reactive.

Remove duplicated spaces before `when matched`

Great, thank you!

HHH-15422 Pick up `CurrentTenantIdentifierResolver` and `MultiTenantConnectionProvider` from BeanContainer if not explicit set

So we have not up until this point allowed `ConnectionProvider`s to be beans, and so: 1. I wonder why it makes sense to do this for the special case of...

HHH-15422 Pick up `CurrentTenantIdentifierResolver` and `MultiTenantConnectionProvider` from BeanContainer if not explicit set

To be clear, because there's apparently a lot of historical confusion on this point. There's three strong reasons why something might need to be a bean: 1. it's going to...

HHH-15422 Pick up `CurrentTenantIdentifierResolver` and `MultiTenantConnectionProvider` from BeanContainer if not explicit set

> If you think about a `MultiTenantConnectionProvider` which can delegate it's work to multiple datasource, it is highly desirable to make it a bean to inject datasources into it. I'm...

HHH-15422 Pick up `CurrentTenantIdentifierResolver` and `MultiTenantConnectionProvider` from BeanContainer if not explicit set

So it turns out that my objections to this pull request actually boil down to only the following, which occurs in two places: ```java @Override public boolean useJpaCompliantCreation() { return...

HHH-15422 Pick up `CurrentTenantIdentifierResolver` and `MultiTenantConnectionProvider` from BeanContainer if not explicit set

> bean in context are not reused Because they would not be beans. That's the point. > it will create two instances, it will create two instances It will create...

HHH-15422 Pick up `CurrentTenantIdentifierResolver` and `MultiTenantConnectionProvider` from BeanContainer if not explicit set

> it will create two instances You need _what_ to be a singleton?