Gavin King

Results 1136 comments of Gavin King

I think this should be fixed by PostgreSQL. I really don't like the idea of just silently swallowing warnings. We really have no clue of the side effects of such...

I have decided not to apply this change. The proposed placement of this test is right in the middle of an admonition that is explaining something completely different, and I...

> I feel like this might be covering https://hibernate.atlassian.net/browse/HHH-10501. It is not. > May I use it as the required Jira reference? No, please open a new issue with a...

> batch_versioned_data=false is particularly useful to enable reporting the exact entity that failed optimistic lock. Since HHH-18586, Hibernate 7 reports a proper `StaleObjectStateException` when a batch update fails. Which means...

(FTR, the actual fix looks reasonable to me, though I'm not an expert on that code.)

Thanks for the contribution, but without a test for the functionality I could not apply the fix. Instead I decided to remove the functionality: https://github.com/hibernate/hibernate-orm/pull/9717

Oh, wait, I did find it, buried in the section on XML: > An entity listener class can define multiple callback methods. However, at most one method of an entity...

Note that https://github.com/jakartaee/persistence/issues/393 is sorta related.

Implicit joins are defined in section 4.4.4, titled "Path Expressions". I agree, for the record, that 4.4.4 is written in a way that's extremely difficult to understand.

So I guess we all agree that the following should always be rejected: ```java @Entity @Table("Super") class Super { ... } @Entity @Table("Sub") class Sub extends Super{ ... } ```...