Gavin King
Gavin King
No problem at all, stuff like this happens all the time.
@yrodiere @Sanne This is really, really fragile. Would it be better to add a `clone()` method to `MetadataImpl` and have Quarkus call that instead?
> Would it be better to add a `clone()` method to `MetadataImpl` and have Quarkus call that instead? Looks like it should be called `trim()`. WDYT?
> Also FWIW `MetadataImpl` is internal, so unless you move `trim` to some SPI, there's a decent chance it'll just get removed in a later commit by someone not aware...
Looks reasonable 👍
P.S. Apologies for taking so long to get to this; we have all been on vacation.
I don't get it: how is this going to result in portable behavior across databases?
> Given that H2, DB2 and PostgreSQL work fine with cast(? as boolean), I am considering to change the implementation of String -> Boolean casting for these for though. That's...
> But I don't think there's any reasonable way to do it without producing truly horrible SQL on most databases. Actually I retract that. Your suggested SQL on the issue...
Yes, it's fine. I already retracted my objection to it.