Gavin King

Results 1136 comments of Gavin King

So as I was saying to Yoann on Zulip, I can see that `CurrentTenantIdentifierResolver` might legitimately be a contextual bean. I absolutely struggle to see how this could ever possibly...

> Most people will just expect a CDI integration to involve actual CDI beans and to comply with scopes I mean, just I don't see that. - Servlets support CDI...

> > as that class can implement `Configurable` and get injected with PU-specific config. > > OK, I get the point, I changed `useJpaCompliantCreation()` to return `true`, please review. Yeah,...

> I think there's a reasonable argument that `CurrentTenantIdentifierResolver` is a special case here Indeed, you could choose to view the `CurrentTenantIdentifierResolver` as precisely a kind of "bridge" between the...

Fine, then I'll let Christian make the call on this. To me it seems weird to change the SQL that was handwritten by the user _if we don't absolutely need...

Closing because this change was incorporated into #10633.

Note that it's going to take some work to finish this off, so it's not for 7.0.

I guess ideally we would just accept whatever ORM accepts.

I guess ideally we would just accept whatever ORM accepts.