Gary Gregory comments

Results 851 comments of


                                            Gary Gregory

Use own validator ClassUtils.getName to get String input

@arturobernalg The PR fails. Just run "mvn" locally before pushing to run the default goals.

hamcrest v2.2

I don't think we need to complicate the pom unless it is a requirement to override hamcrest.

TEXT-126: Adding Sorensen-Dice similarity algoritham

Hi All. Where are we here?

LANG-1677 : Add ReflectionDiffBuilder.setExcludeFieldNames(...) and DiffExclude a…

Hi @debae Thank you for your patience. The code coverage for this new feature is not good enough IMO. Run `mvn clean site`, then browse the site in `target\site\index.html`, navigate...

LANG-1677 : Add ReflectionDiffBuilder.setExcludeFieldNames(...) and DiffExclude a…

I'll take a look over the weekend.

LANG-1677 : Add ReflectionDiffBuilder.setExcludeFieldNames(...) and DiffExclude a…

I'll look over the weekend.

LANG-1400: Add StringUtils.mask() function

Needs discussion, see mailing list WRT to what belongs in Commons Lang vs. Commons Text.

Add module-info for Java 9

The last time I tried to use a jar with a Java 9 class file properly embedded in META-INF it blew up the Android toolchain. It's been a while so...

LANG-1641: GmtTimeZone now implements #equals(Object) using it's time…

Hi @mdbuck77 Thank for your PR. I do not see what this really fixes. If I apply the test portion of the patch, that test class still passes.

LANG-1519 Add zero, positive & negative util methods

-1 in Commons Lang, we had a `NumberUtil`s class in 2.x but it was deprecated and removed in 3.0. That code now lives in Apache Commons Math IIRC. Also, it...