commons-io icon indicating copy to clipboard operation
commons-io copied to clipboard

IO-543-ReversedLinesFileReader-with-RandowFileAccess-API

Open JeanPierrePortier opened this issue 8 years ago • 8 comments

pull request for ticket: https://issues.apache.org/jira/browse/IO-543

  • Added getFilePointer and seek API to ReversedLinesFileReader
  • Added new JUnit tests (ReversedLinesFileReaderTestRandomAccess)

JeanPierrePortier avatar Jul 03 '17 13:07 JeanPierrePortier

Coverage Status

Coverage increased (+0.09%) to 90.086% when pulling a5bc2f8ade9ac5a13e929bf329b8056afecc1124 on JeanPierrePortier:IO-543-ReversedLinesFileReader-with-RandowFileAccess-API into acceb62960971477744f6731bbbc06abbabfe4f3 on apache:master.

coveralls avatar Jul 03 '17 14:07 coveralls

Hi @garydgregory This is a very old PR and I did not work onto it for a long time now. Let me sync with sources; please.

Jean-Pierre-Portier avatar Aug 10 '22 05:08 Jean-Pierre-Portier

Hello @garydgregory , sorry for the delay; tried to sync my mind with current master state (more than 1500 commits behind....) So just pushed a rebased branch with improved unit tests

Jean-Pierre-Portier avatar Aug 11 '22 13:08 Jean-Pierre-Portier

Hello @JeanPierrePortier Thank you for the update. You'll want to run a local command line build with just mvn which runs the default Maven goal. This will make sure you do not cause your branch build here to fail by fixing issues before you push your branch. ATM, you have failures.

garydgregory avatar Aug 11 '22 13:08 garydgregory

Codecov Report

Merging #39 (cdf495f) into master (279a4c4) will decrease coverage by 0.00%. The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master      #39      +/-   ##
============================================
- Coverage     85.66%   85.65%   -0.01%     
+ Complexity     3102     3101       -1     
============================================
  Files           204      204              
  Lines          7368     7370       +2     
  Branches        905      904       -1     
============================================
+ Hits           6312     6313       +1     
  Misses          810      810              
- Partials        246      247       +1     
Impacted Files Coverage Δ
src/main/java/org/apache/commons/io/FileUtils.java 94.42% <100.00%> (-0.04%) :arrow_down:
...ache/commons/io/input/ReversedLinesFileReader.java 90.71% <100.00%> (+3.40%) :arrow_up:
.../apache/commons/io/input/ReadAheadInputStream.java 68.53% <0.00%> (-3.38%) :arrow_down:
.../main/java/org/apache/commons/io/input/Tailer.java 86.06% <0.00%> (+0.49%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Aug 11 '22 13:08 codecov-commenter

Yes just seen this (I just launched mvn verify command) before pushing and it is not enough...

Jean-Pierre-Portier avatar Aug 11 '22 14:08 Jean-Pierre-Portier

Yes just seen this (I just launched mvn verify command) before pushing and it is not enough...

Just run mvn

garydgregory avatar Aug 11 '22 14:08 garydgregory

Last CI run failed for windows env for files not related to this PR. No idea why and failures should not be related to this PR (I do not have windows host for validation)

Jean-Pierre-Portier avatar Aug 11 '22 15:08 Jean-Pierre-Portier