commons-validator JUnit assertThrows

Code could be cleaner if it could be Java 1.8.

I could set <maven.compiler.testSource>1.8</maven.compiler.testSource>... thoughts???

Oct 14 '20 21:10 nhojpatrick

I am ok with Java 8 but others might not be. May you please bring this up on the dev ML? It would be better if using Java 8 would bring benefits to the main code.

Oct 14 '20 23:10 garydgregory

@garydgregory have continued assertThrows email about maven.compiler.testSource.

About the jdk 1.7 build failure, i'm not sure exactly what the issue is as from what i'm aware i've not touched anything to do with japicmp/maven/JApiCmpMojo

Oct 15 '20 11:10 nhojpatrick

Could this get another review and try and get it merged. I'm leaving asserting the exception messages, as it's good practice. You write a test with a set input, the output is also important.

Oct 04 '22 18:10 nhojpatrick

@garydgregory breaking it out into separate pr's, as i keep needing to rebase and often face merge issues, so easier if 1 pr per test. then it might be easier to get them reviewed and merged quicker.

https://github.com/apache/commons-validator/pull/92 https://github.com/apache/commons-validator/pull/93 https://github.com/apache/commons-validator/pull/94 https://github.com/apache/commons-validator/pull/95

Oct 19 '22 19:10 nhojpatrick