commons-math icon indicating copy to clipboard operation
commons-math copied to clipboard

Remove legacy Java versions from dependency statement

Open elharo opened this issue 1 year ago • 8 comments

@garydgregory

elharo avatar Jun 21 '24 14:06 elharo

@elharo That's not what the POM says. It requires Java 8.

garydgregory avatar Jun 21 '24 14:06 garydgregory

which is why I removed the note saying that Java 5 is required

elharo avatar Jun 21 '24 14:06 elharo

I think this change is fine. The reference to Java 1.2 and 1.5 are no longer relevant and adding back a different Java version adds a maintenance burden syncing the required java version across various documentation.

aherbert avatar Jun 21 '24 14:06 aherbert

Java 8 CI for Mac is borked:

Run actions/setup-java@9704b39bf258b59bc04b50fa2dd55e9ed76b47a8
Installed distributions
  Trying to resolve the latest version from remote
  Error: Could not find satisfied version for SemVer '8'. 
  Available versions: 22.0.1+8, 22.0.0+36, 21.0.3+9.0.LTS, 21.0.2+13.0.LTS, 21.0.1+12.0.LTS, 21.0.0+35.0.LTS, 20.0.2+9, 20.0.1+9, 20.0.0+36, 19.0.2+7, 19.0.1+10, 19.0.0+36, 18.0.2+101, 18.0.2+9, 18.0.1+10, 18.0.0+36, 17.0.11+9, 17.0.10+7, 17.0.9+9, 17.0.8+101, 17.0.8+7, 17.0.7+7, 17.0.6+10, 17.0.5+8, 17.0.4+101, 17.0.4+8, 17.0.3+7, 17.0.2+8, 17.0.1+12, 17.0.0+35, 11.0.23+9, 11.0.22+7.1, 11.0.22+7, 11.0.21+9, 11.0.20+101, 11.0.20+8, 11.0.19+7, 11.0.18+10, 11.0.17+8, 11.0.16+101, 11.0.16+8, 11.0.15+10

elharo avatar Jun 21 '24 14:06 elharo

Re MacOS, I think we have to switch the setup-java distribution to zulu. Or just drop the windows and mac os from the actions given the code does not use anything platform dependent. I'll push a change to master using zulu and see what happens.

aherbert avatar Jun 21 '24 14:06 aherbert

Switching to zulu has fixed the master build.

aherbert avatar Jun 21 '24 15:06 aherbert

The simplest is to use macos-13. The title here is "Assume everyone is on Java 5 or later" which is not the case, we need Java 8 or later.

garydgregory avatar Jun 21 '24 16:06 garydgregory

The title is just from the commit message. The code change is to remove statements that spread the dependency information across site documentation (which is evidently not maintained in sync).

aherbert avatar Jun 21 '24 16:06 aherbert