Gary Gregory

Results 851 comments of Gary Gregory

Thanks for the update. I will review later this week but consider java.time classes for more precision.

As you can see here "All checks have failed", please fix those up. https://travis-ci.org/apache/commons-lang/builds/654709829?utm_source=github_status&utm_medium=notification

Can this be used within Commons Lanf itself?

> > > > Can this be used within Commons Lanf itself? > > HI @garydgregory > i.e in --> [ObjectUtil](https://github.com/apache/commons-lang/blob/master/src/main/java/org/apache/commons/lang3/ObjectUtils.java#L249) That does not seem like a very good example...

No rush. I might cut a release candidate next week or so but this is a major change we might only want to do after that.

Hi @belugabehr, Please note that I merged a bug fix today related to string delimiters.

Hi @belugabehr Are you still working on this PR or should it be closed?

You know I am a volunteer right?

> Hi @DaGeRe ! > > Agree that code duplication is bad. But the change could perhaps be changed a little bit to make it easier to accept it in...

@DaGeRe I've made simpler changes. Please see git master.