Gary Gregory comments

Results 851 comments of


                                            Gary Gregory

Avoid Code Duplication: Reuse Sleep from ThreadMonitor

@DaGeRe ping?

[COLLECTIONS-768] Fix flaky Flat3MapTest.testEntrySet()

FYI `Flat3Map` make no order guarantee just like `Map`.

[COLLECTIONS-768] Fix flaky Flat3MapTest.testEntrySet()

@tongxin97 I do not think so. While it is not documented, the iteration order for a Flat3Map is in fact predictable when the size

TEXT-215: Prevent decimal numeric entities from wrongly including hexadecimal characters

https://www.w3.org/TR/REC-xml/#dt-charref Why are illegal entities allowed in the first place? Am I reading the specification incorrectly? The ';' character should be required. IMO this feature creep on our end feels...

TEXT-215: Prevent decimal numeric entities from wrongly including hexadecimal characters

My personal opinion is that we should stick to a specific version of a specification, in this case W3C XML. If we also want to emulate what a browser does...

COMPRESS-614: Use FileTime in SevenZArchiveEntry

Hi @andrebrait Sorry about the noise on git master but our build was broken due to some mistakes in porting from JUnit 4 to 5. Would you mind rebasing on...

COMPRESS-614: Use FileTime in SevenZArchiveEntry

I will review it this weekend.

COMPRESS-614: Use FileTime in SevenZArchiveEntry

Sweet

[LANG-1593] Common behavior for StringUtils join APIs when called with char or String delimiter

@HubertWo Thank you for your update. Please see my comments.

Use own validator ClassUtils.getName to get String input

@arturobernalg Would you rebase on master, please?