Garrett LeSage
Garrett LeSage
One huge issue right now: On page load, the page is white. That's a dealbreaker for a proper dark theme. I guess we can set html or body to `#000`...
I pushed up a bunch of fixes for dark mode. I'm still ignoring the issues that a newer PF would fix; these are ones that affect us specifically and ones...
I don't see a difference @ https://cockpit-logs.us-east-1.linodeobjects.com/pull-17649-20220815-034938-91c590d4-fedora-36/pixeldiff.html#TestStorageStratis-testBasic-copy-fsys-medium But there should be a shadow under the breadcrumb bar @ https://cockpit-logs.us-east-1.linodeobjects.com/pull-17649-20220815-034938-91c590d4-fedora-36/pixeldiff.html#TestServices-testBasic-details-test-fail-mobile I looked at [the doc](https://www.patternfly.org/v4/components/breadcrumb/design-guidelines), but it's way out of date,...
Wow, that (?) icon change is _extremely subtle_. Here's a zoomed-in version:  I'd say the left is better, with consistent rendering of the circle on all edges. On the...
Wow, the toolbar shadow is just so broken. I've been debugging it locally. :scream:
Apologies for the delay: I've been fighting my computer's insistance on underclocking from 3.7 GHz to 400 Mhz all day. It's even doing this when it's in the mid-60s now....
Oh, about looking where the problem is upstream, I want to get that done so I can have a comment about it and file an issue (or _find_ an issue......
Not too many actual code changes in PF: - https://github.com/patternfly/patternfly/compare/prerelease-v4.206.1...prerelease-v4.206.3 Here are the React changes that are possibly relevant: - https://github.com/patternfly/patternfly-react/compare/%40patternfly/react-core%404.228.0...%40patternfly/react-core%404.231.8 - https://github.com/patternfly/patternfly-react/compare/%40patternfly/react-styles%404.78.0...%40patternfly/react-styles%404.81.8 I do see a bunch of changes...
> (A single failure of either sdc or sda1 will kill two stripes.) We probably want to warn about unsafe configurations. Some people may want to run with unsafe setups,...
FWIW, I wrote in-depth about RAID levels @ https://github.com/cockpit-project/cockpit/discussions/16440#discussioncomment-3178556. Summary: - Some RAID levels should never be shown in creation (RAID 2 - 4, 0+1, and _even_ RAID 5). -...