Garrett LeSage

Results 767 comments of Garrett LeSage

@Dorson: Thanks for the link. However, Cockpit is pretty complex, being a mix of PF3, PF4, and a lot of custom code. We'd have to have our own implementation of...

Copy/pasted from https://github.com/martinpitt/performance-graphs/pull/64#issuecomment-702187607: --- Ideally, PatternFly would have a class for dark mode. IIRC, they would enable it at the top of the page _or_ at a specific widget level....

Ideally, we'd try to use PF4's dark mode (with it lands) and have a fallback for non-PF with the example I outlined above (in which we'd probably also drop or...

Removing and updating the colors we use (#15183) was a walk in the direction of this issue. And PatternFly is working on support. Once PF lands dark mode, we can...

> Nobody else asked for this as far as I can remember It's an accessibility feature and a user preference. Over the past few years, it's been showing up almost...

@jchristi: Yeah, Dark Reader is great! I use it on my phone especially (via Firefox on Android). It doesn't really work with Cockpit, however, as we have a bunch of...

Related, upstream PF dark theme proof of concept: https://github.com/patternfly/patternfly/pull/4203

@septatrix: Cockpit has had the modern look of PatternFly 4 for a few years already... If your version of Cockpit is still using PatternFly 3, then you might want to...

@Archef2000: That won't work, as Cockpit has changed a ton since this issue was first opened. We're using PatternFly 4 now, instead of PatternFly 3. And we're using many more...

Note: a _better_ fallback might be to redefine the PF color variables. (And I think this is what PF does for their implementation?) But we'd probably still need a hacky...