Garrett LeSage

Results 767 comments of Garrett LeSage

I tried removing the breakpoint inclusions everywhere, but it turns out whenever a breakpoint is used, the file needs to be included. And whenever a PF component is imported in...

All the places where we import from PatternFly in our CSS files: ![image](https://user-images.githubusercontent.com/10246/178928425-c2333f5b-d7d2-4598-a58f-177d68fd2702.png) (The selected one happens to be different in the file with an unecessary `../../node_modules/` in it that...

Here's a look at the utility classes: Bytes | File -- | -- 2756 | 'node_modules/@patternfly/patternfly/utilities/Accessibility/accessibility.css' 1894 | 'node_modules/@patternfly/patternfly/utilities/Alignment/alignment.css' 15924 | 'node_modules/@patternfly/patternfly/utilities/BackgroundColor/BackgroundColor.css' 1923 | 'node_modules/@patternfly/patternfly/utilities/BoxShadow/box-shadow.css' 3878 | 'node_modules/@patternfly/patternfly/utilities/Display/display.css' 19279 |...

So the utilities have a ton of breakpoints. Some are not needed, but others let you add a utility on some breakpoints but not others. (Ugh.) But they're PF's wrongly...

![image](https://user-images.githubusercontent.com/10246/178958151-c60fded3-5f4c-47a3-a75d-ce3132e88aae.png)

webpack's null-loader (which is deprecated, BTW), prevents loading those files... so they can be loaded by the SCSS build stack instead of webpack, to prevent duplication. What would be ideal...

We have 2 main problems: 1. React and SASS compilation no nothing about each other. 2. Both of these compile steps, `import` (JSX) and `@import` (SASS) copy the CSS, regardless...

This looks like a WebKit rendering bug. We had something _similar_ with a table caption sticky positioning in the past. I'll look into it.

OK, I've looked at it on a quick first pass and it's related to the content being flex items, aligned to the baseline. When I removed the alignment, so they...

This happens for grid too; it's not just flex. ![image](https://user-images.githubusercontent.com/10246/169860632-edb26b1c-1d07-43d1-8491-57a7ad00c664.png) If I set the background to red, you can see that it still selects the text and even changes the...