Garrett LeSage

Results 767 comments of Garrett LeSage

Technically, the `ctrl`+`w` isn't closing the tab (default behavior), but getting caught so that a native dialog gets in the way to prevent the tab from being closed via `beforeUnload`....

If I understand it correctly: That's similar to the sticky keys solution, but only works for control, and I guess is a 1-time toggle (so you have to switch to...

> alt/alt gr instead of ctrl Which doesn't on many keyboards, including ANSI (EN-US) keyboards.

As mentioned before, I've researched all the solutions and the only one that really works as transparently as possible (without a plugin-based approach, which wouldn't be supported now in browsers...

Keyboard shortcuts also work in Cockpit Client, the desktop app on Flathub. https://flathub.org/apps/details/org.cockpit_project.CockpitClient (It's for Linux only, as it has parts of Cockpit embedded within and uses ssh to contact...

The problem with the spacing is because of this: ![image](https://user-images.githubusercontent.com/10246/182802820-53741f1d-4517-4cbc-90d1-c9f32665e27f.png) It should be using [helperText on the input](https://www.patternfly.org/v4/components/form/design-guidelines#helper-text), not the helperText component. They're different things, often used similarly. This is...

> The button is disabled without explanation why. We might want to add * next to those required fields, see [isRequired prop](https://www.patternfly.org/v4/components/text-input#props) We haven't done this in Cockpit yet, but...

@dphaas2004: PatternFly has a section on error messages on the form component design page @ https://www.patternfly.org/v4/components/form/design-guidelines/#errors-and-validation: > When a form field submission results in an error, let users know as...

@dphaas2004: The native date input has issues, sadly. From https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/date#handling_browser_support: > The second problem is the more serious one; with date input supported, the value is normalized to the format...

If PatternFly's isn't working, then we can use the native one, try to be aware of its shortcoming(s), and test cross-browser (in latest Firefox, Chrome, WebKit). And then we can...