Gray Olson

icon indicating a website link https://fusha.moe/ icon indicating an email [email protected]

icon company @EmbarkStudios icon location Stockholm, Sweden icon location Artist, programmer, gamer, bit-twiddler, overall nerd. Rust/graphics dev.

Results 123 comments of Gray Olson

add support for deriving NoUninit on enums with fields

As discussed, I believe the full requirements are: - All variants must be themselves NoUninit - All variants must be the same size - All variants must have no extra...

add support for deriving NoUninit on enums with fields

@Lokathor yes, reviewing it now

add support for deriving NoUninit on enums with fields

Oh! For some reason I thought the `BlahDiscriminant` existed outside that anonymous scope for the `NoUninit` case too, but you're right, it is contained inside. Excellent! Then ignore my hesitancy...

add support for deriving NoUninit on enums with fields

Wait, hm. For the `CheckedBitPattern` case, could we not get rid of the `BlahRawDiscriminant` and just inline the current type expression into the `BlahBits` type instead? I think I would...

add support for deriving NoUninit on enums with fields

Awesome :) Thanks for working on this and applying feedback! Think we can merge whenever @Lokathor would like

Good Idea: safe way to transmute `Vec<Option<&Foo>>` to `Vec<&Foo>`

Isn't this only possible going from `&[&Foo]` to `&[Option]` and not the other way around? Or do you mean that in the owned `Vec` case, we should check all values...

vulkan: Mark `fn mapped_(mut_)slice()` as `unsafe`

I think that this is likely a good way forward. It might be the best to just not expose `mapped_slice` at all and only ever expose the raw base pointer,...

vulkan: Mark `fn mapped_(mut_)slice()` as `unsafe`

I'm a fan. I think the list of apis could be something like ```rust /// `offset` is in bytes from start of allocation, `len` is the number of `T`s in...

vulkan: Mark `fn mapped_(mut_)slice()` as `unsafe`

My take is probably that things are "fine" just as is for now, people are unlikely to change to new apis between now and the near-ish future where we could...

vulkan: Mark `fn mapped_(mut_)slice()` as `unsafe`

Opened https://github.com/EmbarkStudios/presser/pull/5 which implements basically the idea I discussed above, atop which it should be fairly easy to implement similar APIs in `gpu-allocator`, though probably not all of them are...