frzyc comments

Results 109 comments of


                                            frzyc

Optimizer runs out of memory on certain conditions

![image](https://github.com/frzyc/genshin-optimizer/assets/1754901/4d05623b-63c4-488d-8a41-3fc25a3e2a59) I was unable to reproduce, is there anything else I can do to reproduce the issue?

Convert Level input to TextField

Thanks, feel free to ping me if you have any questions

Convert Level input to TextField

You are right, it was not correctly referenced in the original PR to close this.

Tally should update on add/remove, not all events

Thanks, let me know if you have any questions

after v10 migration clean up

In theory the amendment to the migration logic in https://github.com/frzyc/genshin-optimizer/pull/2021 should get rid of a lot of these cases. Existing migrated databases may still need these tools, the theory is...

Add sortable tables to Archive page

Yes to all of the above.

Convert multi opt interface to a horizontal scrolling interface

Although I understand the reasoning for this suggestion, in a UX perspective, our UI tend to overflow in the Y direction, and for a low-effort mobile compatible layout, it is...

Convert multi opt interface to a horizontal scrolling interface

flowing vertically for mobile only is extra effort. I am just saying for MVP flowing vertically is probably easier.

Add names characters limit and truncate

> > I think more truncation may be needed for team and loadout names: > > In format of ( display / max string length) > > > > *...

Remove weapon/artifact edit/swap modal from Build Settings

I think fundamentally you would at least need to keep the weapon selector, because that is the weapon optimizer use by default, so you can create a build with another...