frzyc

>Artifact Upgrader still doesn't optimize a build, it just does a single swap. The use case of leveling up main stats is a separate use case from the artifact upgrader....

Actually, I think in this case, since somnia is the only discord.js runtime, it would actually make sense to retain any discord.js code in app/somnia for now(since its not usable...

Another question: since somnia bot will likely have SR archive as well, where should we put the somnia discord.js lib? or do we further split up the libs: lib/common/somnia -...

My concern here is bikeshedding, I don't see a clear organization in the somnia code to warrant libification yet, that is not to say I won't support libification attempts in...

Might be a cause to remove scanner and GOOD doc link from quick link

You are right, I am not sure what we can do to make this more accurate. Perhaps instead of a b/w highpass, we apply a better filter in this section?...

No regression tests (every time we bring it up seems to be more of a hassel than just taking new screenshots from in-game anyways) Looks like good progress. the bandpass...

Also, can you bundling in l10n for these strings https://github.com/frzyc/genshin-optimizer/pull/2440#discussion_r1775930079, I believe they can be partially retrieved from dm.

looks mostly organized for me. for the singular/plural, I think i prefer in the way indicated by the [i18next format](https://www.i18next.com/translation-function/plurals): ``` "character_one": "character" "character_other": "characters" ``` rather than the `label.one`/`label.many`

@HassnHamada The roll tables are actually generated in [another repo](https://github.com/frzyc/genshin-rounding), but the issue is that we can't deterministically generate every rounded rolls. we have a separate "override" file that you...