frzyc comments

Results 109 comments of


                                            frzyc

import weapon svg icons

@Jenfufu FYI I updated the scope of this PR: > Adding in the svg icons should complete this issue. a separate task will be made to replace the existing image...

Bold the selected header tab text

> @frzyc just want to confirm the task is for the headers on the '/archive' page ? The header values are already in bold. Should i just make the font...

Bold the selected header tab text

Completed.

ZO: Issue with 4p-2p enforcement in solver

I think we should make 4p/2p mutually exclusive in that case, through would need to talk to @lantua about implementation

SRO Add ascension+bonusAbility+statBoost checks for statBoosts in char util

I would say this should be low priority, especially for MVP, unless you think you can do it relatively quickly (say less than 2 hours)

SRO Add ascension+bonusAbility+statBoost checks for statBoosts in char util

Fair, I did the PR without touching any of the datamine, so I drew the line there.

translation painge

Made the whole NextJS dev too laggy. Will explore other options for i18n

Prayers Artifact Sets Not Working

Likely an issue in https://github.com/frzyc/genshin-optimizer/blob/master/libs/gi/ui/src/components/artifact/editor/index.tsx

@tisseandorius I am still not convinced that Custom Target expression is the solution towards somewhat niche usecases. Can you elaborate on which usecases that existing multi-target features cannot cover? I...