Anthony Frehner

Results 68 comments of Anthony Frehner

Ugh, yeah, another situation where the cart gets into an impossible state ☹️

`import.meta` environment variables are only available in code that is being bundled. Can you try following this [vite guide](https://vitejs.dev/config/#environment-variables) and seeing if that works for you?

I think Stackblitz may also only be on 16?

>@frehner in your research did you come across non-200 JSON responses? According to [the docs](https://shopify.dev/api/storefront#status_and_error_codes) (scroll down to the section `4xx and 5xx status codes`) it seems like most of...

>What do you think, should useShopQuery be throwing? Already it does for failed to fetch. But should it be throwing for non-200 responses? Hmm, I don't know. I would have...

This is one of the areas that should work better in Hydrogen v2, given the recent announcement https://remix.run/blog/remixing-shopify and the work that we're doing there.

Prior to v2 I think is unlikely. However, there's now also the [hydrogen-ui](https://github.com/shopify/hydrogen-ui) project where the source code for ProductOptionsProvider will now live. So it's hard to say whether the...

Adding Vitest for hydrogen-ui, so we're on that from the start. As we migrate components over, we can translate the existing Jest tests to Vitest.

@mrkldshv Let's hold off for a little bit - there's still some discussion about the future of the hydrogen-ui package that we need to figure out. I'll respond in this...

I'll see if it's useful / possible to setup that situation with Vitest in the existing repo, and if so, we can at least get started there and migrate tests,...