Anthony Frehner

Results 68 comments of Anthony Frehner

Actually going to reopen so I don't forget to migrate this stuff to the hydrogen package too.

From what I can tell, this is more of an issue with the demo-store than with the `useProductOptions` hook. The `ProductForm` component attempts to set the selected options based on...

That said, I think there's also room to improve `ProductOptionsProvider` using the info gained from https://beta.reactjs.org/learn/you-might-not-need-an-effect and reduce the number of useEffects there as well.

It's been awhile since I have worked in liquid, but I remember just straight up putting the variant ID in the search params, which seemed like it would make it...

Does the `urlRerouteOnly` argument work for you in this situation? https://single-spa.js.org/docs/api#start

Seems like a good idea - not because it is popular, but because it is right. Reading it over - >Before adopting the Contributor Covenant take the time to discuss...

it looks like #348 and its related PR #322 are also related here. (I too am interested in the feature of multiple CSS outputs - one per JS chunk, ideally...

I would love this feature too - I left a comment in #245, but essentially it seems this repo is in maintenance mode. Perhaps a couple of us could all...

Ah, just ran into this trying to use the ESM version of the build. Seems... weird to have an esm build but not actually have it work? 🤷‍♀