Anthony Frehner

Results 68 comments of Anthony Frehner

>@frehner minor nit but we never provided native esm, our pkg clarifies it's es-import syntax module only. those 2 are different. Hm, I'm probably reading [this](https://github.com/ReactiveX/rxjs/blob/c3a0ae7b9569c5703e8d53c27d03f766640aafd4/docs_app/content/guide/v6/pipeable-operators.md#build-and-treeshaking) wrong then: >Published along...

I believe [this line creates the options for browserslist](https://github.com/amilajack/eslint-plugin-compat/blob/b2cd1c61b2c86e0ebfbe8149568b438d647a9cda/src/helpers.ts#L185) and then is passed to `browserslist()` [here later](https://github.com/amilajack/eslint-plugin-compat/blob/b2cd1c61b2c86e0ebfbe8149568b438d647a9cda/src/helpers.ts#L212C40-L212C40), so it appears that currently there isn't an easy way to set the...

>Many libraries that supports many bundlers and type of apps like https://github.com/mui. Not use the exports field. Yup, that's likely because the exports field is fairly recent, and also adopting...

Thanks! It's probably not something I'll do in the near future, as it would require creating and updating a ton of different examples and configurations. Maybe one day, though.

Awesome, thank you! I’ll get this updated

Ok, in reviewing this, I've been thinking about the balance (as a library author) of indicating that you have explicitly tested your library with [new version] vs warning devs that...

Thanks for the feedback! I'm going to move this over the Hydrogen repo. 👍

>but this PR doesn't seem to do much for the current type-safety, it maybe just discourages people from adding more type-unsafe code moving forwards. Thoughts? Yeah, that was the goal...

> A few things to think about: > > * How will this impact developers jumping into Hydrogen for the first time? Good question. Are we asking about Hydrogen the...

Regarding TypeScript: as I'm going in and playing around with fixing the types for the [`Button` component](https://github.com/Shopify/h2/blob/v0.x-2022-10/templates/demo-store/app/components/Button.tsx), it has led me to find some errors (or, better put, behaviors that...