hydrogen icon indicating copy to clipboard operation
hydrogen copied to clipboard

Move Minimum Node Version to 18

Open vlucas opened this issue 2 years ago • 4 comments

Description

Ensure that the minimum Node version is 18. This ensures that globals like fetch, formData, etc. are always available.

Node 18 - New globally available browser-compatible APIs

Additional context

Also updated starter templates

vlucas avatar Jul 13 '22 21:07 vlucas

Looks like we need to poke the Oxygen team to upgrade Node:

error [email protected]: The engine “node” is incompatible with this module. Expected version “>=18". Got “16.16.0”

vlucas avatar Jul 13 '22 21:07 vlucas

I think Stackblitz may also only be on 16?

frehner avatar Jul 13 '22 22:07 frehner

@frehner That's a good point on StackBlitz. We need to ensure they support Node 18 before we can push this out and then drop all our polyfills.

vlucas avatar Jul 14 '22 13:07 vlucas

I left a comment on the StackBlitz issue for custom Node versions. We will see what they say or do.

vlucas avatar Jul 14 '22 21:07 vlucas

Oxygen deployed a preview of your bl-fix-xss2 branch. Details:

Storefront Status Preview link Deployment details Last update (UTC)
third-party-queries-caching ⏳ In progress (Logs) - Inspect deployment March 14, 2024 5:14 PM
optimistic-cart-ui ⏳ In progress (Logs) - Inspect deployment March 14, 2024 5:14 PM
skeleton ⏳ In progress (Logs) - Inspect deployment March 14, 2024 5:14 PM
custom-cart-method ⏳ In progress (Logs) - Inspect deployment March 14, 2024 5:14 PM
subscriptions ⏳ In progress (Logs) - Inspect deployment March 14, 2024 5:14 PM
vite ✅ Successful (Logs) Preview deployment Inspect deployment March 12, 2024 7:29 PM

Learn more about Hydrogen's GitHub integration.

shopify[bot] avatar Mar 12 '24 18:03 shopify[bot]

We detected some changes in packages/*/package.json or packages/*/src, and there are no updates in the .changeset. If the changes are user-facing and should cause a version bump, run npm run changeset add to track your changes and include them in the next release CHANGELOG. If you are making simple updates to examples or documentation, you do not need to add a changeset.

github-actions[bot] avatar Mar 12 '24 18:03 github-actions[bot]