Results 844 comments of Francisco Giordano

One thing to note is that our library currently supports trees of depth > 256, while an `uint256` index would not support that. Another concern is that it may be...

In the [docs for merkletreejs](https://github.com/miguelmota/merkletreejs/blob/master/docs/classes/_src_merkletree_.merkletree.md) I see that some functions accept an `index` argument. Do you know what that number is supposed to be?

Worth noting that for a balanced tree I think that index is identical to the one that was originally proposed in the linked PRs.

Thanks for the suggestion @owocki! I thought the ENS distribution was really clever in how it guided users to set a delegate during claiming. I didn't know GTC had done...

Now that we have gas reporting, with this PR it should be easy to compare the cost of our current approach (cast everything to a Bytes32Set) versus duplicating the code...

This is a good point, we can't assume `decimals` is present. For ERC20Wrapper we handled it properly: https://github.com/OpenZeppelin/openzeppelin-contracts/blob/6ab8d6a67e3281ab062bdbe4df32b95c6409ee6d/contracts/token/ERC20/extensions/ERC20Wrapper.sol#L28-L34 > Even if both tokens expose decimals the method is for usability,...

I don't understand the second option, can you explain it in words? We can add the implementation of decimals based on ERC20Wrapper, but I think we should also add `_initialAssetToShareRatio()`.

You're right that the documentation for this function is not clear. We should improve it. > Is it expected that a `Successful`, `Defeated` or `Queued` proposal that's not yet executed...

@arpu I'd suggest looking into [The Graph](https://thegraph.com/).

@arpu No, it isn't decentralized, at least not yet.