Felix Exner (fexner)

Results 391 comments of Felix Exner (fexner)

My intuitive impression would be that an issue's due date should have preference. An assigned milestone's due date should only be the fallback in my opinion.

Yes, I have to agree that [this comment](https://github.com/ralphbean/bugwarrior/issues/385#issuecomment-247843532) makes a lot of sense to me.

@ryneeverett should I start working on this? I could address this while looking at my old #818...

@urmahp good point! @gavanderhoorn Thanks for the hints!

Added downstream tests for ROS driver. @urmahp you will add something for the ISAAC driver? Unfortunately, it's probably not going to be that easy as this is not a catkin...

> As a short-cut you _could_ add a manifest to the directory containing the main `CMakeLists.txt`. > > It would still not make it a "Catkin package", but with `build_type`...

At least for this repo, tests [aren't run](https://github.com/UniversalRobots/Universal_Robots_Client_Library/runs/2418018437?check_suite_focus=true#step:4:1440), which is why I have setup a second [workflow running the tests](https://github.com/UniversalRobots/Universal_Robots_Client_Library/runs/2418018527?check_suite_focus=true#step:8:1), which only calls `make test`.

The falling robot is actually on our priority ToDo list at the moment. @RobertWilbrandt can say more about this. If it helps I would not see a downside in adding...

This is something we want to do in general, which is why this should not get closed. Therefore, added the ToDo label.

The necessary changes will come with the [next sync](https://discourse.ros.org/t/preparing-for-humble-sync-and-patch-release-2022-11-21/28234). I don't quite understand why the `use_sim_time` parameter should make things work without those changes, but since it is working with...