Felix Lange

Results 442 comments of Felix Lange

See also https://github.com/ledgerwatch/erigon/issues/9179#issuecomment-1943790257

Just checked and you're right: the behavior did change. I think the new behavior is more correct, but a config option could be added to disable 'clearing' of slices and...

Sorry didn't have much time last few weeks. What should it be renamed to? I thought `exwm-workspace-switch-to-buffer` made sense because of the analogy to `exwm-workspace-switch`. The best I can come...

`net_version` does exist in the server implementation, and it does return the networkID. So it should work. Maybe it's an issue with a proxy? @nidhi-singh02 are you pointing your ethclient...

Still a bit WIP, needs some more fixes to tests.

Fixed the test by allowing unspecified IP in node. I'm doing this to allow nodes with 0.0.0.0 to round-trip the `enode://` URL encoding/parsing. We check for a valid IP in...

The images are here: https://github.com/ethereum/go-ethereum/tree/website/public/images/docs

The CI is ok now. Please add the new hooks to the changelog in core/tracing/changelog.md

Yes we could. But if it's enabled like in this PR, there wont be any filtering. There is currently a circular dependency in the stack where the discovery instance is...

Yeah, the test doesn't pass and I need to investigate.