Felix Lange comments

Results 442 comments of


                                            Felix Lange

rpc: add limit for batch request and response size

The client can also accept requests from the server (and the server is implemented using Client) :)

rpc: add limit for batch request and response size

I've changed my mind a little bit, `SetBatchLimits` on `Client` is not a good idea because it would require a connection reset (which you implemented). The limits can now be...

rpc: add limit for batch request and response size

@mmsqe You can leave this as-is now. I will go over it and get the PR across the finish line as soon as I have time for it.

rpc: add limit for batch request and response size

I promise I'll get back to this very soon!

rpc: add limit for batch request and response size

I was finally able to fix this up properly. With the latest changes, the client will now properly handle wrong size batch responses and return early without relying on the...

rpc: add limit for batch request and response size

@holiman PTAL

p2p/discover: bootnodes not retried often enough when table becomes empty

This is definitely known, but it's also expected behavior. Discovery cannot work without bootstrapping and the lookup iterator will block until the table contains some nodes to do the lookup...

p2p/discover: bootnodes not retried often enough when table becomes empty

Maybe I am misunderstanding your issue. AFAIK the lookupIterator will try to access the bootnodes repeatedly if they do not work. Please provide log output of `geth --vmodule=p2p/*=5`. The logs...

p2p/discover: bootnodes not retried often enough when table becomes empty

Thank you for the logs. It looks like the part that's broken is that `newRandomLookup` doesn't retry re-inserting the bootnodes when the discovery table is empty.

ethdb, core/rawdb, cmd: Adds Redis database engine, refs: #26754

I'm also pretty curious about it.