Felix Lange

Results 442 comments of Felix Lange

> What we should verify, is whether the geth RPC server does indeed return the correct error code when calling eth_subscribe over HTTP. I've checked this, and it does not:...

I have implemented the idea above. We should still debate if this is a useful direction or not. One thing I noticed is, changing the error code for 'notifications not...

@zhiqiangxu let me know what you think about the proposed solution

> what I originally wanted was just to expose the underlying protocol and let the caller decide what to do. I understand that. But what we found while exploring it,...

@rjl493456442 > Currently blsync is a standalone command outside of Geth. I would vote to convert it as a service inside of Geth. This service can be started and stopped...

Related: https://github.com/ethereum/go-ethereum/issues/22374

We are still waiting for the spec change to be made before shipping anything in geth. It is likely that a spec change requires a champion who will defend the...

I think we should add them to gethclient first

We will not add `eth_fillTransaction` to ethclient, because it has a different approach to transaction sending that requires you to construct the tx yourself on the client side. `eth_resend` is...

Please remove changes in other client's Dockerfiles from this PR.