go-ethereum icon indicating copy to clipboard operation
go-ethereum copied to clipboard

Use DiscoveryV5 as a source of peers

Open thaarok opened this issue 2 years ago • 3 comments

In the current version, when DiscoveryV5 is enabled, it runs and discovers peers, however they are not pushed into the dialScheduler, so they are actually not used.

thaarok avatar Apr 15 '24 08:04 thaarok

@fjl Should we start using discv5 for full nodes? AFAIK we're not currently using it at all anywhere

karalabe avatar Apr 16 '24 12:04 karalabe

Yes we could. But if it's enabled like in this PR, there wont be any filtering. There is currently a circular dependency in the stack where the discovery instance is not available until the client was started, but we'd need to access it earlier to create the filtered node stream. I will solve it, but it's not as easy as this PR.

fjl avatar Apr 16 '24 12:04 fjl

Ok, feel free to close this, if you are going to handle it by a different way.

thaarok avatar Apr 16 '24 12:04 thaarok