Nick Fitzgerald
Nick Fitzgerald
I'd like to re-add the keyboard navigation that used to exist before the React-ification for selecting individual bugs with either vim-style hjkl or arrows and then opening in a new...
But yeah, clicking is pretty useless.
> I just have one concern regarding how allocation limits interact with the value for the minimum chunk size allocation. If a limit is set that is below `DEFAULT_CHUNK_SIZE_WITHOUT_FOOTER`, all...
https://github.com/fitzgen/bumpalo/runs/7239112120?check_suite_focus=true#step:5:126 Looks like `abs_diff` wasn't introduced until Rust 1.60, and our MSRV is 1.50. Mind open coding `abs_diff` here?
Looks like CI is still failing: https://github.com/fitzgen/bumpalo/runs/7286188380?check_suite_focus=true#step:5:342 ``` failures: ---- oom_instead_of_bump_pointer_overflow stdout ---- Layout::from_size_align errored: invalid parameters to Layout::from_size_align note: test did not panic as expected error: test failed, to...
I don't have time to look into the old tests at the moment, if you can get them passing and send a PR then I can review that.
I doubt there is a leak here, since I think valgrind (which we run tests under in CI) would have complained about that.
Add support for sub-arenas that can be reset in a LIFO order, without resetting the whole bump arena
Was thinking about this a little more today, came up with the following API: ```rust /// The backing storage for bump allocation. pub struct Region { _storage: (), } impl...
Happy to receive a PR doing this.
Would need to run each of the fuzz targets on CI (in separate jobs so we get parallelism) for ~5 minutes as well.