bumpalo icon indicating copy to clipboard operation
bumpalo copied to clipboard

Fix `cargo miri test --all-features`

Open zetanumbers opened this issue 2 years ago • 2 comments

  • [x] -Zmiri-ignore-leaks baseline
  • [x] -Zmiri-tag-raw-pointers
  • [x] -Zmiri-strict-provenance (cargo miri --version f76ebd6 2022-07-02)
  • [ ] eliminate -Zmiri-ignore-leaks

Also adds test_skip_miri_quickchecks default feature.

Fixes #166, fixes #164

zetanumbers avatar Jun 27 '22 19:06 zetanumbers

So i ran cargo miri test --test quickchecks ..., and it have spuriously failed on alloc_strs and can_allocate_big_values tests, only indicating that one of its spawned cargo miri process exited with error code 255. Could this be OOM bc of a leak?

UPDATE: running 1 quicktest on alloc_strs with leak detection enabled completes successfully.

zetanumbers avatar Jun 29 '22 05:06 zetanumbers

I doubt there is a leak here, since I think valgrind (which we run tests under in CI) would have complained about that.

fitzgen avatar Jul 05 '22 18:07 fitzgen

Thank you for your patience and for sticking with this PR!

fitzgen avatar Aug 15 '22 17:08 fitzgen

No problem. Sorry for the long delay.

zetanumbers avatar Aug 15 '22 20:08 zetanumbers