bumpalo icon indicating copy to clipboard operation
bumpalo copied to clipboard

Published 20 hours ago • verified publisher icon fitzgen

Switch from `quickcheck` to `cargo-fuzz`

Open zetanumbers opened this issue 2 years ago • 4 comments

quickcheck tests are super long for miri (14m24s enabled vs. 1m48s disabled). Perhaps it is better to separate "try to break the program by massaging input for a while" tests and usual tests? cargo-fuzz defines fuzz targets, which already are separate from tests.

zetanumbers avatar Jun 27 '22 18:06 zetanumbers

Happy to receive a PR doing this.

fitzgen avatar Jun 27 '22 19:06 fitzgen

Would need to run each of the fuzz targets on CI (in separate jobs so we get parallelism) for ~5 minutes as well.

fitzgen avatar Jun 27 '22 19:06 fitzgen

For now i made it possible to not enable quickcheck via similarly named feature in #168.

zetanumbers avatar Jun 27 '22 19:06 zetanumbers

I think it could be better to not switch to cargo-fuzz if we would run 1 test in quickcheck. This would allow to check UB in the quickcheck! code. However it would be desirable to write some predefined values to increase code coverage and for determinism.

zetanumbers avatar Jun 29 '22 15:06 zetanumbers