Nick Fitzgerald

Results 394 comments of Nick Fitzgerald

> Would it be worth documenting this somewhere? this = "always `no_std`" or something else? If you end up writing a crate that adds this helper, I'm happy to link...

This makes sense to me, but in the `bumpalo` crate. `ToString` doesn't require `Display`, but instead has a blanket implementation for all `T: Display`. I think it makes sense to...

FWIW, my understanding of the MPL is also that it is not viral. Only changes to MPL'd source files are required to be releaaed under the MPL. Just linking /...

A while ago I got criterion compiling on wasm: https://github.com/fitzgen/criterion.rs/tree/wasm We need some extensions to `wasm-bindgen-test` for profiling and things though. Also, we have ["add benchmarking support to `wasm-bindgen-test`"](https://github.com/fitzgen/rfcs-1/blob/2019-roadmap/text/007-2019-roadmap.md#monitoring-profiling-and-testing-infrastructure) so...

+1 for MIT or BSD.

I think we wouldn't want to use `failure::Error` in this crate, but instead `#[derive(Failure)]` on a custom error enum.

> silly because the gimli crates are using error-chain Would love to get PRs to move to failure, btw.

Basically, wasm defines another binary format for libraries and executables, and if goblin is trying to exhaustively support binary formats that are widely in use today (or likely to be...

I agree that the rustwasm organization isn't the right place or people to maintain Emscripten documentation. Emscripten experts are the right people to maintain it, and being integrated with the...

[Is your npm up to date?](https://rustwasm.github.io/docs/book/game-of-life/setup.html#npm) Is there any error output? Can you include more info?