fisker Cheung

Results 1279 comments of fisker Cheung

I don't know, I didn't get response https://github.com/eslint/eslint/issues/19468#issuecomment-2690641343

> It's not a valid code. I think it's valid. But I don't really care if it can be parsed since nobody use it, more care about the error location.

> I checked acorn before, recall it does a thorough parsing of regex. I recall it's over 1000 lines of code. Yes acorn validates regex, lots of code.

I don't know the story behind, but yes. Two.more parsers [swc](https://play.swc.rs/?version=1.7.36&code=H4sIAAAAAAAAA9OPcdLS5wIAebbVTAYAAAA%3D&config=H4sIAAAAAAAAA1WPSw7DIAwF9zkF8rrbdtE79BAWdSIifrKJVBTl7iUE0maH3xsz8jooBbNoeKq1PMsQkYX4nEsi2Sf8lARIOxTNJia49XaWvRrRCtVoOxpIyBOluiX3hoMNQajjLXPGmzH%2FC3VwkUnkCu4o%2BsnSVTc0JbjwXmrZDkk50qF%2FwA%2FqsvNjMPLqm4kXGrYvhlQioBQBAAA%3D) [oxc](https://playground.oxc.rs/#eNpFjrEOwyAMRP/FY4WUnbFDvyILoaZCAjuySdso4t8Lqkgm37OtuzvAg4Vpnu+3CQww2ANkoz50p+K+YItsaCBFKkOr5xVP2PPCaVARRxpYMtjgkmI1sDpRlObYdHcZ+nwdC89PfGHPbpAjxRCvExXh9Ej86dXeKAtrq/DPqPUHFgJFcQ==) oxc shows errors, but ast is generated.

So, are you fine with this change?

Can you send a separate PR for this first? > Don't trim spaces other than ASCII whitespace at the beginning or end of paragraphs And we can use [this module](https://github.com/prettier/prettier/blob/main/src/utils/html-whitespace-utils.js)...

Interesting, https://bugs.webkit.org/show_bug.cgi?id=13159 seems we already made mistake in HTML/Handlebars printer.

Anyway, I think we should reuse `htmlWhitespaceUtils`, but consider remove `\f` in future if it really matters.

> A newline between [Chinese & Japanese & CJK punctuations] should not be converted to a space. Didn't get it.

Should't we only need make sure the output equivalence in html? Ah, maybe you are right, in markdown one single new line doesn't generate a space. But should not related...