fisker Cheung
fisker Cheung
The diff is quite big, I didn't read all, but it will good to add [this case](https://github.com/tc39/proposal-decorators/issues/556#issue-3062870719) to tests if missing. ```js class A { @decorators[0] method() {} } ```
How did you implement `Data.TaggedError` shouldn't it use like ```js export class QueryError extends Data.TaggedError {} ``` Or ```js export class QueryError extends Data.createTaggedError("") {} ``` ?
I'm fine to ignore it. Would you like send a PR?
> I don’t think [].concat() should be part of prefer-array-flat and thus should be removed. It definitely should be in `prefer-array-flat`. It's common (even recommended) to use `[].concat()` to flat...
Fine with any decision you make, because `tokens` don't have `.range` either. We can live with that.
We support many es parsers, have to pick one.
We planned to use tokens years ago, but I guess we can remove that now, since other maintainers do not agree to use tokens.
We also plan to remove comment attach if https://github.com/prettier/prettier/pull/17491 works, should also improve performance?
> I thought of this when looking at [ArnaudBarre/prettier-oxc-parser#benchmark](https://github.com/ArnaudBarre/prettier-oxc-parser?rgh-link-date=2025-05-17T21%3A32%3A25.000Z#benchmark) . If Prettier could set `tokens: false, ranges: false` on Babel, or even use [#16935](https://github.com/babel/babel/pull/16935), then Babel's performance might be close...
A class with some method like `close`/`destroy` maybe should be reported too.