fisker Cheung

Results 1275 comments of fisker Cheung

I took a look at this problem, but `conditionalGroup` is implemented in this way from the begining (8 years ago) https://github.com/prettier/prettier/pull/3 And this specific case was broken by https://github.com/prettier/prettier/pull/15795 😢...

@Dunqing I'm sorry I don't understand what's probelm in [this case](https://prettier.io/playground/#N4Igxg9gdgLgprEAuEAdKqaYDZxgAgBMBLAM1PwF58o4B3fAGTAGcARM0gCloYGUYAJ2JQA5h3J84ARwCuCMHC65SMAJQAaGvXwDhYiaSlyFS4aIAW6raVlQwMYtHxd0mdzBUwAklEJwADw03LFDsaFE4FhgAWQBDGDALPggAMTjBEMw1fGAs0LiWFjhBGAA6aOEHAFE5OOwuAAdBOBIwBLgAYXrsTog7GC0ABjU3DFDMZtbidvhu7F7+2ABqZbGPTELi0oqhGZha2XrlOFVffyD8AEZRjHGPAHoH-Hb7OGx8ZohFIpFRfMwLRgskEUHwpHqxXyAF81CANCAII1HNAWMhQBlBBA6AAFDIINEoep0OIATzRCIARoI4mAANZ4PhxAC2cEYIjgyAh2GKCIglIAVnAHAB1GmNZAgKbbABunKpNPpjMatL+yCE8gRxWZxHVgk1IECjRKxFZsHqAHljTSYBBBDiICxiCioJKEIR4YaAtbTQgYPUAColKAZYhRLmQuBav64ACKsgg8AjPKjIAFLACfBjcHjic5SG5vJAcjzOKxjUJIEKAFpaK1Wp6hHFiNg-n1mcy4pKep6nWJcABBGB7SmyeA4krs2jJotWZnYEUWZ1RFWKKRQJ2OGXO0mS1gUkAy+TnP18MDCZEDvwCUm4Gepr7FMVxCUoaUlOWekTbGBluKiTt7wRFVBG2SVKTiSl3k9Fo5GIFo-wArsC0jBF-UpEViEIGALGQAAmBFZGKANIMJQtUzgZkoMIfxCEYOIxCOSJUjtTthzVIkxwgT1mhEGBMOw3CkCuPChmhaEgA) https://github.com/prettier/prettier/pull/18196 seems not changing anything either. [Playground from #18196](https://deploy-preview-18196--prettier.netlify.app/playground/#N4Igxg9gdgLgprEAuEAdKqaYDZxgAgBMBLAM1PwF58o4B3fAGTAGcARM0gCloYGUYAJ2JQA5h3J84ARwCuCMHC65SMAJQAaGvXwDhYiaSlyFS4aIAW6raVlQwMYtHxd0mdzBUwAklEJwADw03LFDsaFE4FhgAWQBDGDALPggAMTjBEMw1fGAs0LiWFjhBGAA6aOEHAFE5OOwuAAdBOBIwBLgAYXrsTog7GC0ABjU3DFDMZtbidvhu7F7+2ABqZbGPTELi0oqhGZha2XrlOFVffyD8AEZRjHGPAHoH-Hb7OGx8ZohFIpFRfMwLRgskEUHwpHqxXyAF81CANCAII1HNAWMhQBlBBA6AAFDIINEoep0OIATzRCIARoI4mAANZ4PhxAC2cEYIjgyAh2GKCIglIAVnAHAB1GmNZAgKbbABunKpNPpjMatL+yCE8gRxWZxHVgk1IECjRKxFZsHqAHljTSYBBBDiICxiCioJKEIR4YaAtbTQgYPUAColKAZYhRLmQuBav64ACKsgg8AjPKjIAFLACfBjcHjic5SG5vJAcjzOKxjUJIEKAFpaK1Wp6hHFiNg-n1mcy4pKep6nWJcABBGB7SmyeA4krs2jJotWZnYEUWZ1RFWKKRQJ2OGXO0mS1gUkAy+TnP18MDCZEDvwCUm4Gepr7FMVxCUoaUlOWekTbGBluKiTt7wRFVBG2SVKTiSl3k9ZoRBgEViEIGALGQK4ACYhgRFo5GIFo-wArsC0jBF-UpBCkJQpA0IRWRigDSDCULVM4GZKDCH8QhGDiMQjkiVI7U7Yc1SJMcIBAaFoSAA)

## Fail ```js import foo from './foo?query=foo.js'; ``` ## Pass ```js import foo from './foo.mjs'; ``` ```js import foo from './foo.json' assert { type: "json" }; ``` (This can't test...

Please also take a look at https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/new-rule.md