fisker Cheung

Results 1279 comments of fisker Cheung

I don't think these related to languages, I don't understand why we should care how browser renders, we need make sure the input/output generate the same HTML. If they are...

Sorry, I don't have the knowledge about how should they wrap, and I nerver use "proseWrap". I trust your judgment.

> I'm glad you seem to understand it. For the record, I don't. I still think we only need make sure we doesn't change the output "HTML". ```markdown a b....

@thorn0 You are more familiar with the markdown text wrapping. Do you have a comment about the problem here?

How about `prefer-named-backreference` with option to report only if backreference is duplicate names.

> The current implementation uses the Identifier node for judgment. > > However, this node appears in many cases, so it may cause misjudgment. Maybe this isn't a good way...

Not sure about the strategy for unknown properties here. ``` window[foo]; const foo = 'name'; window[foo]; const foo = 'not-name'; window[foo]; ``` I think we should ignore them, or simply...

> I prefer to ignore all computed properties. Agree, let's ignore computed properties then.

I use the first one a lot, I thought It only run `.map` once? Can you explain why the first one should be avoid?

> @fisker Because you end up iterating through `bars` twice. Oh, right. I see. In that case ```js cont foo = bar.map(fn) for (const gamma of foo) { gamma('ray') }...