fisker Cheung

Results 1279 comments of fisker Cheung

It's fine to merge into `main`, we do format changes in minor releases. (We probably won't release 2.x though)

I've tried to only update `@babel/parser` in https://github.com/prettier/prettier/pull/15139, and eveyting seems just works.

The dev version passed, means the build script need update, > TypeError: Cannot read properties of undefined (reading 'platform') Should be `process.platform` , caused by https://github.com/prettier/prettier/blob/6ed37ad85731e4e62d81481d40dfd98c6a675a10/scripts/build/build-javascript-module.js#L116

This file size increased https://github.com/prettier/prettier/actions/runs/5648163263/job/15299782481?pr=15157#step:4:289 This replacement may not working. https://github.com/prettier/prettier/blob/6ed37ad85731e4e62d81481d40dfd98c6a675a10/scripts/build/config.js#L397-L400

> Would it be possible for Prettier to compile @babel/parser down to Node.js 14 when bundling it? Yes, we can do when bundling. > The alternative could be that we...

esbuild should be able to transform `??=`. Maybe our target is wrong? https://github.com/prettier/prettier/blob/825425c57f00268abaf3964b441a7649c8004ba0/scripts/build/build-javascript-module.js#L227 We can also use `supported` option https://esbuild.github.io/api/#supported

We used bundle modules into `vendors/` and load from there. https://github.com/prettier/prettier/pull/12217 https://github.com/prettier/prettier/pull/12377

@nicolo-ribaudo I think everything is working as expected now. Since we are not going to release new version in near future, I think we can merge. Questions: 1. Will we...

> @fisker Would you be accepting a PR for this? See https://github.com/prettier/prettier/pull/16112