fisker Cheung

Results 1279 comments of fisker Cheung

Need update `peerDependencies` for `@babel/eslint-parser` https://github.com/babel/babel/blob/f7a7715c896968a9e650d267cd7008b6daf8bfe5/eslint/babel-eslint-parser/package.json#L31 Blocking eslint-plugin-unicorn https://github.com/sindresorhus/eslint-plugin-unicorn/actions/runs/8579682135/job/23514924056?pr=2250#step:4:14

You may wan try use `json-stringify` parser for these files. https://prettier.io/docs/en/options#parser

Why don't you start with just one rule. 😄

`prefer-object-from-entries` is another special version of `no-array-reduce`.

I'm not familiar with this codebase, after a quick look, it seems we use `vm` to load prettier, there are some esm support issues in `vm`, but I'm not very...

BTW, I saw this "A dynamic import callback was not specified." in our tests (JEST) a lot when migrate prettier to ESM. We end up make tests passes with a...

You can use [` ["importAttributes", { deprecatedAssertSyntax: true }]`](https://github.com/prettier/prettier/blob/d170b8f31dee2a415da8e7ba6ed4d2bb3fb733cd/src/language-js/parse/babel.js#L49) to support both new and legacy syntax.

Making the first move https://github.com/xojs/eslint-config-xo/pull/86 https://github.com/xojs/eslint-config-xo-space/pull/10

It's a good idea, but like impossible to implement without type info.

> I agree, this could be useful. > > It should prevent setting properties on `window`, `global`, and `globalThis`. How do we do with setting `window` properties, `location`, `name`, `cookie`?...