fisker Cheung

Results 1279 comments of fisker Cheung

Sorry that I have to rebase to reduce diff in https://github.com/prettier/prettier-regression-testing/issues/435#issuecomment-1908674770

Wow, we are breaking (or maybe improving) a LOT... https://github.com/prettier/prettier-regression-testing/issues/435#issuecomment-1908695983 Good opportunity to add more tests. Better add all of them to our tests first (in other PR).

> removing if (rest.length % 2 === 1) {{ parts.push([]); } can cause bug. `fill` should alway have even length, if not then there must something wrong.

> Feel free to revert [e85797f](https://github.com/prettier/prettier/pull/15909/commits/e85797f53a2dc10b078510bbdb444534e7ab95a4) if you regard type safety as important. `getDocParts` should not be used anymore. It's a legacy function should be removed. #15568

If you worry about edge cases, 1. odd length should be thrown 2. zero-length should be ignored, otherwise `undefined` will be pushed to doc, and it make sense to have...

The `printParagraph` part looks good and fixed lots of bugs, do you think we can extract this part to seperate PR?

> Should we start from a PR at the point of https://github.com/seiyab/prettier/commit/064f77df8ca0dc9e3a086169af7716971da6ff35 as the first step? Yes, please

Sorry, this will break html, we can't accept it. ```html a a alert(a.value === b.value); ```

Do you have a reference for the updated pattern?

Thanks for working on this, but I don't think we can simply change the regexp, we need to implement logic from https://github.com/vuejs/core/blob/f1068fc60ca511f68ff0aaedcc18b39124791d29/packages/compiler-core/src/transforms/vModel.ts and https://github.com/vuejs/core/blob/f1068fc60ca511f68ff0aaedcc18b39124791d29/packages/compiler-core/src/transforms/vOn.ts